Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations sections in Download modal is showing up when opening it from Tomograms table #1293

Open
lauramarcos opened this issue Oct 31, 2024 · 2 comments
Assignees
Labels
bug Something isn't working frontend severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo)

Comments

@lauramarcos
Copy link
Collaborator

Describe the bug
Annotations text in Download modal should not be displayed when opening it from Tomograms table

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://cryoetdataportal.czscience.com/runs/364?table-tab=Tomograms
  2. Click on Download link in tomograms table
  3. See error

Screenshots

Screen.Recording.2024-10-31.at.3.10.36.PM.mov

Desktop (please complete the following information):

  • OS: Sonoma 14.7
  • Browser Chrome
@lauramarcos lauramarcos added bug Something isn't working frontend severity - low little impact to the overall functionality of the Portal (e.g., wrong sized button) labels Oct 31, 2024
@lauramarcos lauramarcos changed the title Annotations text in Download modal is showing up when opening it from Tomograms table Annotations sections in Download modal is showing up when opening it from Tomograms table Oct 31, 2024
@junxini junxini added severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo) and removed severity - low little impact to the overall functionality of the Portal (e.g., wrong sized button) labels Nov 7, 2024
@junxini
Copy link
Contributor

junxini commented Nov 7, 2024

@Janeece i left a comment in the designs to confirm. it does seem out of place to download all annotations when we're specifically clicking to download a single tomogram

@Janeece
Copy link
Collaborator

Janeece commented Nov 13, 2024

RE reported bug: Implementation is correct -- this was an in-flight change to address not having standardized annotations, sorry it wasnt (design change is here). The callout text aligned on by the team was universal for all download options (excluding "download dataset").

Please note that the original design's section cover sheet was labeled "archived" and a link to the new design is linked.

@Janeece i left a comment in the designs to confirm. it does seem out of place to download all annotations when we're specifically clicking to download a single tomogram

@junxini I think this is different than the reported bug? As i understand, the bug is about the callout text. Your comment seems to be about our approach to use the existing download flow instead of creating a separate flow for downloading individual tomograms from table — happy to discuss why we went this route and if we should log a design request ticket if thats the case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend severity - medium May interrupt the Portal, causing it to behave in a less than optimal way (e.g., broken link, typo)
Projects
None yet
Development

No branches or pull requests

4 participants