feat: definition and search updates #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking great! One nitpick: can you update the search bar right side padding to 24px so it aligns with the end of the table? |
codemonkey800
force-pushed
the
jeremy/definition-and-search-updates
branch
from
3ac7ab5
to
996d2d8
Compare
kne42
approved these changes
Nov 5, 2024
frontend/packages/data-portal/app/components/TablePageLayout/TablePageLayout.tsx
Outdated
Show resolved
Hide resolved
ehoops-cz
reviewed
Nov 5, 2024
| @@ -1,6 +1,6 @@ | |||
| export * from '../TablePageLayout/TableCount' | |||
There was a problem hiding this comment.
Not sure if this is the time for refactoring, but I recently learned about barrel files hurting performance:
https://marvinh.dev/blog/speeding-up-javascript-ecosystem-part-7/
There was a problem hiding this comment.
interesting. i wonder if this is the reason tooling like ESLint feels so slow lately
There was a problem hiding this comment.
ooh possibly, I knew it had some perf overhead but not this much 😭 I created an issue for this: #1310
ehoops-cz
approved these changes
Nov 5, 2024
codemonkey800
force-pushed
the
jeremy/definition-and-search-updates
branch
from
3f122a8
to
11c610e
Compare
github-actions bot
added a commit
that referenced
this pull request
Nov 6, 2024
🤖 I have created a release *beep* *boop* --- ## [1.36.0](web-v1.35.1...web-v1.36.0) (2024-11-06) ### ✨ Features * challenge status banner ([#1319](#1319)) ([1bd0bff](1bd0bff)) * definition and search updates ([#1298](#1298)) ([58e36ea](58e36ea)) * ML challenge launch copy updates ([#1318](#1318)) ([7ceff67](7ceff67)) * order datasets by release date ([#1320](#1320)) ([788c178](788c178)) * universal empty states ([#1295](#1295)) ([ef64faa](ef64faa)) ### 🐞 Bug Fixes * download code snippets ([#1315](#1315)) ([b137eb4](b137eb4)) * fix single run page view tomogram button ([#1325](#1325)) ([da6902c](da6902c)) * fix view tomogram button greyed out error ([#1323](#1323)) ([5a6ca7a](5a6ca7a)) * table hover state ([#1300](#1300)) ([800ad33](800ad33)) ### 🧹 Miscellaneous Chores * fix ml challenge page nits ([#1324](#1324)) ([9ba9fa7](9ba9fa7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1267
Demos
Browse Datasets
https://dev-table-def.cryoet.dev.si.czi.technology/browse-data/datasets
Browse Depositions
https://dev-table-def.cryoet.dev.si.czi.technology/browse-data/depositions