Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add fft module #74

Merged
merged 5 commits into from
Dec 6, 2024
Merged

[feat] Add fft module #74

merged 5 commits into from
Dec 6, 2024

Conversation

Routhleck
Copy link
Collaborator

@Routhleck Routhleck commented Dec 6, 2024

This pull request introduces several significant changes to the brainunit package, including the addition of FFT functionality, a new hash method, and the inclusion of copyright headers in various test files.

New FFT Functionality:

Enhancements to brainunit/_base.py:

  • Added __hash__ method to Unit class to enable hashing based on unit attributes.

Copyright Headers:

  • Added copyright headers to several test files:
    • brainunit/lax/_lax_accept_unitless_test.py
    • brainunit/lax/_lax_array_creation_test.py
    • brainunit/lax/_lax_change_unit_test.py
    • brainunit/lax/_lax_keep_unit_test.py
    • brainunit/lax/_lax_linalg_test.py
    • brainunit/lax/_lax_remove_unit_test.py
    • brainunit/lax/_misc_test.py
    • brainunit/math/_fun_keep_unit_test.py

@Routhleck Routhleck marked this pull request as ready for review December 6, 2024 06:46
Copy link
Collaborator

@chaoming0625 chaoming0625 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@chaoming0625 chaoming0625 merged commit b484821 into main Dec 6, 2024
24 checks passed
@chaoming0625 chaoming0625 deleted the fft branch December 6, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants