Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove not used variables to fix #102 #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

canasdiaz
Copy link

Fix error #102 by removing unused variables in an exception at arthur/arthur.py and in two unit tests at tests/test_arthur.py.

Fix error chaoss#102 by removing unused variables in an exception at
arthur/arthur.py and in two unit tests at test_arthur.py.

Signed-off-by: Luis Cañas-Díaz <lcanas@bitergia.com>
@coveralls
Copy link

coveralls commented Oct 30, 2019

Coverage Status

Coverage remained the same at 85.468% when pulling 017afad on sanacl:fix_pyflakes_errors into 7c0ec65 on chaoss:master.

@canasdiaz
Copy link
Author

canasdiaz commented Oct 30, 2019

I forced an update to add the signature of the commit but it is not visible here. Do I need to create another PR for that? can't I update this somehow?

@canasdiaz
Copy link
Author

Forget my comment above. I did not pushed the changes to the correct origin. Now it is ready. 😅 🤓

Copy link
Member

@valeriocos valeriocos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sanacl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants