Add Kubernetes service account auth for Vault #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mirimi <kathy_huang101@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## master #82 +/- ##
==========================================
+ Coverage 83.29% 83.29% +<.01%
==========================================
Files 23 23
Lines 1467 1479 +12
==========================================
+ Hits 1222 1232 +10
- Misses 245 247 +2
Continue to review full report at Codecov.
|
Contributor
|
Oh, that's an awesome idea! I'll review that this week as best as I can :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppRole support was just added, and since
chaostoolkitcan be run from within pods, it would be nice to be able to retrieve secrets from Vault using a configured Kubernetes service account.Signed-off-by: mirimi kathy_huang101@hotmail.com