Skip to content
This repository has been archived by the owner on Jun 15, 2023. It is now read-only.

Fixes openWindow function def and call #865

Merged
merged 1 commit into from
Sep 23, 2015

Conversation

cvd
Copy link
Contributor

@cvd cvd commented Sep 23, 2015

Fixes failing test in master that is holding up a couple open PRs: #780, #864, #861

Interested in getting #780 finalized and having the Backbone dependency updated. Any interest in separating the features in #780 from the upgrade of backbone?

❤️

paulmillr added a commit that referenced this pull request Sep 23, 2015
Fixes openWindow function def and call
@paulmillr paulmillr merged commit 6aad818 into chaplinjs:master Sep 23, 2015
@paulmillr
Copy link
Contributor

Any interest in separating the features in #780 from the upgrade of backbone

Yes.

@paulmillr
Copy link
Contributor

Thank you!

@Florian-R
Copy link
Contributor

@cvd FWIW, i have a (messy) PR opened against @akre54 's fork which fix the failing tests in #780 see akre54#4 if you want to help with the review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants