Makes VTOrc mandatory (bitpoke#368)

* test: update vtorc test to not specify a config for vtorc Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: make vtorc compulsary by adding a default Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove repair replication code from the operator Signed-off-by: Manan Gupta <manan@planetscale.com> * test: augment test to also verify VTOrc fixes primary being read-only Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: release notes changes Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com>
chapsuk · Feb 2, 2023 · 8ac7bcb · 8ac7bcb
1 parent 0c8c4aa
commit 8ac7bcb
Show file tree

Hide file tree

Showing 7 changed files with 37 additions and 490 deletions.
diff --git a/docs/release-notes/2_9_0_summary.md b/docs/release-notes/2_9_0_summary.md
@@ -4,4 +4,9 @@
 
 The config `enforceSemiSync` is removed from the `VitessReplicationSpec`. This configuration is no longer requied.
 If the users want to configure semi-sync replication, they should set the `durabilityPolicy` config to `semi_sync` in the keyspace specification.
-This change of not using `enforceSemiSync` should be done before upgrading to `2.9.0` version of the operator otherwise the configuration would not be accepted.
+This change of not using `enforceSemiSync` should be done before upgrading to `2.9.0` version of the operator otherwise the configuration would not be accepted.
+
+### VTOrc becomes mandatory
+
+VTOrc is now a **required** component of Vitess starting from v16. So, the vitess-operator will always run
+a VTOrc instance for a keyspace, even if its configuration is unspecified.
diff --git a/pkg/apis/planetscale/v2/vitesskeyspace_defaults.go b/pkg/apis/planetscale/v2/vitesskeyspace_defaults.go
@@ -32,9 +32,9 @@ func DefaultVitessKeyspace(dst *VitessKeyspace) {
 }
 
 func DefaultVitessOrchestrator(vtorc **VitessOrchestratorSpec) {
-	// If no vtorc is specified, we don't launch any.
+	// If no vtorc is specified, we want to start one since it is now a mandatory component of Vitess.
 	if *vtorc == nil {
-		return
+		*vtorc = &VitessOrchestratorSpec{}
 	}
 	if len((*vtorc).Resources.Requests) == 0 {
 		(*vtorc).Resources.Requests = corev1.ResourceList{