Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package: lap #999

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add package: lap #999

wants to merge 2 commits into from

Conversation

IsakTheHacker
Copy link
Contributor

@IsakTheHacker IsakTheHacker commented Oct 13, 2023

@mhsmith
Copy link
Member

mhsmith commented Oct 17, 2023

Thanks for the PR. To add a new package, we need a test script to verify that it works. Please do the following:

  • Follow the instructions in "Testing a package" in the README.
  • Push your test script to this PR.
  • Post a comment saying which Python versions and ABIs you have tested.

@mhsmith
Copy link
Member

mhsmith commented Dec 9, 2023

Changing to draft until tests are ready.

@mhsmith mhsmith marked this pull request as draft December 9, 2023 20:41
@mhsmith
Copy link
Member

mhsmith commented Nov 11, 2024

@IsakTheHacker: What's the status of this PR? I don't think the tests could pass as they stand, as they contain a reference to an undefined function approx. Maybe this should be replaced with assertAlmostEqual.

Once you've successfully built and tested this package, please let me know which Python versions and ABIs you've tested, and I'll add it to the public repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install "lap": numpy not found
2 participants