Refactor squelch #225
Merged
Refactor squelch #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing squelch algorithm into a new class in an attempt to decouple from the actual demodulation.
The expectation here is no diff in the demodulated output against current code and I verified that using the AM and NFM recordings that I have. (NOTE: I need to make a bug fix on the
unstablebranch and pushed that for reference here: https://github.com/charlie-foxtrot/RTLSDR-Airband/tree/refactor_squelch_baseline)There are several places that caused diff (although insignificant) in my first pass, so I made changes here to eliminate the diff and commented as a TODO. I'll remove those and clean up in a following PR (because it will cause some diff).
There is a change in scan mode in that each frequency has its own
Squelchobject (and therefore state counters), where previouslyagcsqfor squelch status was at the channel levelThere is a change in the text UI in that it now shows the squelch level when either manually set or computed, where previously it would show the noise level (not squelch) when the squelch was being computed.