Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor squelch update #226

Merged
merged 7 commits into from
Feb 8, 2021
Merged

Refactor squelch update #226

merged 7 commits into from
Feb 8, 2021

Conversation

charlie-foxtrot
Copy link
Owner

This PR is based on #225 but makes cleanup that causes very minor diff. For example shifting delay by 2 samples will increase/decrease squelch time and thereby the audio output by that number of samples.

My intent was to merge #225 first followed by this, so if anyone has a problem they could roll back to just after #225 merges to know if it was due to one of these minor changes or due to the refactoring in general.

With that said, it may be easier to review this PR rather than #225 (ie this doesn't have a bunch of TODO comments and throwaway code)

@starvald
Copy link

starvald commented Feb 2, 2021

had it running about 10 hours with no issues so far.

@charlie-foxtrot
Copy link
Owner Author

I'm having some changes in channel bleed (ie the post-bandwidth squelching) that I wasn't expecting so hold off on merging this, but #225 is looking good

@szpajder
Copy link
Collaborator

szpajder commented Feb 6, 2021

I skipped #225 and I'm testing this one right now. Works well so far.

Can't comment on the channel bleed issue though, as I don't have any densely spaced channels that would be active at the same time.

@starvald
Copy link

starvald commented Feb 6, 2021

same, marine band spacing is pretty wide.

@charlie-foxtrot
Copy link
Owner Author

Commit dde2990 has the fix for cross channel bleed. I also rolled back the noise floor update because it caused squelch to open too soon.

Turns out the current squelch code is quite good, even if I had no idea what it was doing ;)

With that said, im going to keep trying to make improvements. Next step (under another PR) will be to try and and improve the flappy squelch. First thought I had was to keep squelch open through the CLOSING phase and allow to go directly back to OPEN if there is still power (or power has returned).

This PR should be good to merge (please merge #225 first) and I'll open a new PR with actual improvements.

@charlie-foxtrot
Copy link
Owner Author

accidentally included a makefile change in dde2990 that has been rolled back in 48fd9be

@szpajder szpajder merged commit cfdfb41 into charlie-foxtrot:unstable Feb 8, 2021
@charlie-foxtrot charlie-foxtrot deleted the refactor_squelch_update branch June 12, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants