From 1710d9d74f9107db031d9a8f050d361395ce06cb Mon Sep 17 00:00:00 2001
From: Christian Rocha <christian@rocha.is>
Date: Thu, 10 Oct 2024 15:29:23 -0400
Subject: [PATCH] chore(help): add full help test to support #554

---
 go.mod                                        |  2 +-
 go.sum                                        |  4 +-
 help/help_test.go                             | 38 +++++++++++++++++++
 .../TestFullHelp/full_help_20_width.golden    |  1 +
 .../TestFullHelp/full_help_30_width.golden    |  2 +
 .../TestFullHelp/full_help_40_width.golden    |  3 ++
 6 files changed, 47 insertions(+), 3 deletions(-)
 create mode 100644 help/help_test.go
 create mode 100644 help/testdata/TestFullHelp/full_help_20_width.golden
 create mode 100644 help/testdata/TestFullHelp/full_help_30_width.golden
 create mode 100644 help/testdata/TestFullHelp/full_help_40_width.golden

diff --git a/go.mod b/go.mod
index 1b53f262..95d68177 100644
--- a/go.mod
+++ b/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/charmbracelet/harmonica v0.2.0
 	github.com/charmbracelet/lipgloss v0.13.0
 	github.com/charmbracelet/x/ansi v0.3.2
-	github.com/charmbracelet/x/exp/golden v0.0.0-20240815200342-61de596daa2b
+	github.com/charmbracelet/x/exp/golden v0.0.0-20241011142426-46044092ad91
 	github.com/dustin/go-humanize v1.0.1
 	github.com/lucasb-eyer/go-colorful v1.2.0
 	github.com/mattn/go-runewidth v0.0.16
diff --git a/go.sum b/go.sum
index fafd9e28..bbb72b1e 100644
--- a/go.sum
+++ b/go.sum
@@ -14,8 +14,8 @@ github.com/charmbracelet/lipgloss v0.13.0 h1:4X3PPeoWEDCMvzDvGmTajSyYPcZM4+y8sCA
 github.com/charmbracelet/lipgloss v0.13.0/go.mod h1:nw4zy0SBX/F/eAO1cWdcvy6qnkDUxr8Lw7dvFrAIbbY=
 github.com/charmbracelet/x/ansi v0.3.2 h1:wsEwgAN+C9U06l9dCVMX0/L3x7ptvY1qmjMwyfE6USY=
 github.com/charmbracelet/x/ansi v0.3.2/go.mod h1:dk73KoMTT5AX5BsX0KrqhsTqAnhZZoCBjs7dGWp4Ktw=
-github.com/charmbracelet/x/exp/golden v0.0.0-20240815200342-61de596daa2b h1:MnAMdlwSltxJyULnrYbkZpp4k58Co7Tah3ciKhSNo0Q=
-github.com/charmbracelet/x/exp/golden v0.0.0-20240815200342-61de596daa2b/go.mod h1:wDlXFlCrmJ8J+swcL/MnGUuYnqgQdW9rhSD61oNMb6U=
+github.com/charmbracelet/x/exp/golden v0.0.0-20241011142426-46044092ad91 h1:payRxjMjKgx2PaCWLZ4p3ro9y97+TVLZNaRZgJwSVDQ=
+github.com/charmbracelet/x/exp/golden v0.0.0-20241011142426-46044092ad91/go.mod h1:wDlXFlCrmJ8J+swcL/MnGUuYnqgQdW9rhSD61oNMb6U=
 github.com/charmbracelet/x/term v0.2.0 h1:cNB9Ot9q8I711MyZ7myUR5HFWL/lc3OpU8jZ4hwm0x0=
 github.com/charmbracelet/x/term v0.2.0/go.mod h1:GVxgxAbjUrmpvIINHIQnJJKpMlHiZ4cktEQCN6GWyF0=
 github.com/dustin/go-humanize v1.0.1 h1:GzkhY7T5VNhEkwH0PVJgjz+fX1rhBrR7pRT3mDkpeCY=
diff --git a/help/help_test.go b/help/help_test.go
new file mode 100644
index 00000000..79601d78
--- /dev/null
+++ b/help/help_test.go
@@ -0,0 +1,38 @@
+package help
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/charmbracelet/x/exp/golden"
+
+	"github.com/charmbracelet/bubbles/key"
+)
+
+func TestFullHelp(t *testing.T) {
+	m := New()
+	m.FullSeparator = " | "
+	k := key.WithKeys("x")
+	kb := [][]key.Binding{
+		{
+			key.NewBinding(k, key.WithHelp("enter", "continue")),
+		},
+		{
+			key.NewBinding(k, key.WithHelp("esc", "back")),
+			key.NewBinding(k, key.WithHelp("?", "help")),
+		},
+		{
+			key.NewBinding(k, key.WithHelp("H", "home")),
+			key.NewBinding(k, key.WithHelp("ctrl+c", "quit")),
+			key.NewBinding(k, key.WithHelp("ctrl+l", "log")),
+		},
+	}
+
+	for _, w := range []int{20, 30, 40} {
+		t.Run(fmt.Sprintf("full help %d width", w), func(t *testing.T) {
+			m.Width = w
+			s := m.FullHelpView(kb)
+			golden.RequireEqual(t, []byte(s))
+		})
+	}
+}
diff --git a/help/testdata/TestFullHelp/full_help_20_width.golden b/help/testdata/TestFullHelp/full_help_20_width.golden
new file mode 100644
index 00000000..e8c569b1
--- /dev/null
+++ b/help/testdata/TestFullHelp/full_help_20_width.golden
@@ -0,0 +1 @@
+enter continue …
\ No newline at end of file
diff --git a/help/testdata/TestFullHelp/full_help_30_width.golden b/help/testdata/TestFullHelp/full_help_30_width.golden
new file mode 100644
index 00000000..1183a10e
--- /dev/null
+++ b/help/testdata/TestFullHelp/full_help_30_width.golden
@@ -0,0 +1,2 @@
+enter continue | esc back …
+                 ?   help  
\ No newline at end of file
diff --git a/help/testdata/TestFullHelp/full_help_40_width.golden b/help/testdata/TestFullHelp/full_help_40_width.golden
new file mode 100644
index 00000000..e0227d09
--- /dev/null
+++ b/help/testdata/TestFullHelp/full_help_40_width.golden
@@ -0,0 +1,3 @@
+enter continue | esc back | H      home
+                 ?   help   ctrl+c quit
+                            ctrl+l log 
\ No newline at end of file