Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast fail and cancel other arch builds when one arch encounters a failure #1431

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

addyess
Copy link
Member

@addyess addyess commented Sep 22, 2023

If a specific charm recipe creates multiple arch builds -- and any one or more of those builds fails during the polling phase, cancel all the other arch builds still pending/running and fail quickly

Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fast fail lgtm; did you mean to include the kcp/lxd spec in this pr?

jobs/validate/kcp-on-lxd-spec Outdated Show resolved Hide resolved
jobs/validate/kcp-on-lxd-spec Outdated Show resolved Hide resolved
jobs/validate/kcp-on-lxd-spec Outdated Show resolved Hide resolved
jobs/validate/kcp-on-lxd-spec Outdated Show resolved Hide resolved
@addyess
Copy link
Member Author

addyess commented Sep 25, 2023

the fast fail lgtm; did you mean to include the kcp/lxd spec in this pr?

Nope, that was a mistake. thanks for catching

@addyess addyess merged commit 14ced56 into main Sep 26, 2023
6 checks passed
@addyess addyess deleted the akd/charm-build-fast-fail branch September 26, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants