Fix validation to work with ops charms #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cynerva
changed the title
|
OK, with the changes in this PR together with the change in juju-solutions/interface-kube-control#42, I'm getting passing validation runs now. |
addyess
reviewed
Dec 7, 2023
Comment on lines
+2070
to
+2071
| if cloud in ["azure", "ec2", "gce", "openstack", "vsphere"]: | ||
| assert label == cloud |
addyess
approved these changes
Dec 7, 2023
|
Yeah. I don't really like it. The skipped tests are covering features and integrations that no longer exist. Some of those features might come back in a later release - that's the part I don't like. I think we have to skip these tests for the initial 1.29 release though, given that our plan is to ship without those features, right? |
kwmonroe
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully so we can start getting some validation runs against the ops charms.
I wasn't quite able to do a full run of this today - my cluster blew up when I ran
test_service_cidr_expansion. Will try again tomorrow.