Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull oci-images through proxy on the lxd #1476

Merged
merged 8 commits into from
Feb 9, 2024
Merged

Pull oci-images through proxy on the lxd #1476

merged 8 commits into from
Feb 9, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Feb 8, 2024

Mark below if this PR requires a job refresh (jjb) after merge:

  • Needs jjb after merge

Please make sure to open PR's against the correct code:

  • For integration tests, please make changes in jobs/integration
  • For validation envs, jobs/validate
  • For MicroK8s,jobs/microk8s
  • For charm/bundle builds, jobs/build-charms

kwmonroe
kwmonroe reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels weird to me. Why do we need to treat nvcr.io differently? Why not treat all image hosts with the same proxy settings?

Let's figure that out before merging.

@addyess addyess force-pushed the akd/sync-oci-through-proxy branch 2 times, most recently from 48dc2d4 to 49a9ce0 Compare February 8, 2024 20:04
@addyess addyess force-pushed the akd/sync-oci-through-proxy branch 2 times, most recently from 7e929f5 to eeb63a5 Compare February 8, 2024 20:30
@addyess addyess force-pushed the akd/sync-oci-through-proxy branch 3 times, most recently from aa85d6e to a6758b4 Compare February 8, 2024 21:32
@addyess addyess requested a review from kwmonroe February 9, 2024 17:17
kwmonroe
kwmonroe approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kwmonroe kwmonroe merged commit ed94d81 into main Feb 9, 2024
6 checks passed
@kwmonroe kwmonroe deleted the akd/sync-oci-through-proxy branch February 9, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwmonroe kwmonroe kwmonroe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addyess @kwmonroe