Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp docs fails on node v12.18.4 - (Chart.js 2.9) #7863

Closed
alessandroasm opened this issue Oct 7, 2020 · 1 comment
Closed

gulp docs fails on node v12.18.4 - (Chart.js 2.9) #7863

alessandroasm opened this issue Oct 7, 2020 · 1 comment

Comments

@alessandroasm
Copy link

Expected Behavior

gulp docs succeeds

Current Behavior

[14:25:36] Using gulpfile ~/src/github/Chart.js/gulpfile.js
[14:25:36] Starting 'docs'...
info: installing 5 plugins using npm@3.9.2 
info:  
info: installing plugin "search-plus" 
info: install plugin "search-plus" (*) from NPM with version 1.0.3 
/home/alessandro/src/github/Chart.js/node_modules/npm/node_modules/graceful-fs/polyfills.js:287
      if (cb) cb.apply(this, arguments)
                 ^

TypeError: cb.apply is not a function
    at /home/alessandro/src/github/Chart.js/node_modules/npm/node_modules/graceful-fs/polyfills.js:287:18
    at FSReqCallback.oncomplete (fs.js:169:5)

Possible Solution

Steps to Reproduce

Run gulp docs on node v12.18.4

Context

This is blocking PRs on 2.9 branch:
PR #7853
PR #7854

Related issue: GitbookIO/gitbook-cli#110

Environment

  • Chart.js version: 2.9
  • Browser name and version:
  • Link to your project:
@alessandroasm
Copy link
Author

The issue is that gitbook-cli still uses old dependencies that are not compatible with node v12.18.3 or later, specifically graceful-fs v4.1.11.

This happens because an optional options argument was added to fs.fstat:
https://nodejs.org/dist/latest-v12.x/docs/api/fs.html#fs_fs_fstat_fd_options_callback

Since gitbook-cli is deprecated, I'm thinking about pushing a PR forcing travis to use node v12.18.2.

alessandroasm added a commit to alessandroasm/Chart.js that referenced this issue Oct 7, 2020
Due to an issue with deprecated deps (gitbook-cli), forcing travis to and older
compatible version of nodejs.

Fixes chartjs#7863
etimberg pushed a commit that referenced this issue Oct 8, 2020
Due to an issue with deprecated deps (gitbook-cli), forcing travis to and older
compatible version of nodejs.

Fixes #7863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants