Replace deprecated String.prototype.substr()#10243
Merged
etimberg merged 1 commit intochartjs:masterfrom Mar 18, 2022
CommanderRoot:rm-deprecated-substr
Merged
Replace deprecated String.prototype.substr()#10243etimberg merged 1 commit intochartjs:masterfrom CommanderRoot:rm-deprecated-substr
etimberg merged 1 commit intochartjs:masterfrom
CommanderRoot:rm-deprecated-substr
Conversation
LeeLenaleee
reviewed
Mar 18, 2022
src/helpers/helpers.core.js
Outdated
| } | ||
| const type = Object.prototype.toString.call(value); | ||
| if (type.substr(0, 7) === '[object' && type.substr(-6) === 'Array]') { | ||
| if (type.startsWith('[object') && type.endsWith('Array]')) { |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (type.startsWith('[object') && type.endsWith('Array]')) { | |
| if (type.substring(0, 7) === '[Object]' && type.substring(type.length-6) === 'Array]') { |
Bit better performance as starts and endWith
Contributor
Author
There was a problem hiding this comment.
Alright I removed the startsWith and endsWith usage
String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with similar functions which aren't deprecated. Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
kurkle
approved these changes
Mar 18, 2022
Contributor
|
I have removed my post, sorry. It was in the wrong project |
LeeLenaleee
approved these changes
Mar 18, 2022
etimberg
approved these changes
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.prototype.substr() is deprecated so we replace it with functions which work similarily but aren't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.