Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify check undefinded #11501

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

Connormiha
Copy link
Contributor

I've simplified the check for undefined a bit. In this case, there is no need for an additional typeof check. Modern browsers do not allow overwriting the global undefined. This was only possible in Internet Explorer up to version 9.

@etimberg etimberg added this to the Version 4.4.7 milestone Nov 18, 2024
@etimberg etimberg merged commit 49256c6 into chartjs:master Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants