-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addListener and removeListener should be only invoked on truthy values #11685
Merged
etimberg
merged 1 commit into
chartjs:master
from
DAcodedBEAT:event-listener-arg-validation
Feb 28, 2024
Merged
addListener and removeListener should be only invoked on truthy values #11685
etimberg
merged 1 commit into
chartjs:master
from
DAcodedBEAT:event-listener-arg-validation
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeLenaleee
approved these changes
Feb 27, 2024
etimberg
approved these changes
Feb 27, 2024
Thanks for the approvals @LeeLenaleee and @etimberg! |
Merged it now; we don't have a date on a next release but I think we're getting close. @LeeLenaleee thoughts? |
There are no enhancements merged so if we rename the milsestone from 4.5.0 to 4.4.2 and create a new 4.5.0 we can do a bugfix release |
i renamed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #11677, this issue is experienced in a few libraries integrating chart.js (such as #11295, samber/chartjs-plugin-datasource-prometheus#40, sgratzl/chartjs-chart-graph#79)
By ensuring that
addEventListener
andremoveEventListener
are called on truth-y values, Chart.js can prevent these TypeErrors from occurring and therefore make implementing applications more stable when integrating chart.js.Closes #11677