Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Chart.{Type} classes #5868

Merged
merged 1 commit into from
Nov 29, 2018
Merged

Deprecate Chart.{Type} classes #5868

merged 1 commit into from
Nov 29, 2018

Commits on Nov 28, 2018

  1. Deprecate Chart.{Type} classes 

    It looks like these classes are a legacy from version 1 but we actually never promoted their usage. Instead, the regular way to create a chart is to set the type in the config, for example: `new Chart(ctx, {type: 'bar'})`. Some types are actually missing (no `Chart.HorizontalBar` or `Chart.Pie`) but it's also not scalable because it can easily conflict with other classes scoped under the `Chart` namespace.
    @simonbrunel
    simonbrunel committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    530282c View commit details
    Browse the repository at this point in the history