Fix animation regression from 5331 #6108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the quick fix @kurkle! I don't know the animation code well enough to review, so will let the others review this one |
etimberg
previously approved these changes
Mar 2, 2019
I though an animation could only be cancelled, where do we reset the start time for an existing animation? |
|
Went through the issue with @simonbrunel and found out its really just because if we start at |
nagix
approved these changes
Mar 3, 2019
simonbrunel
approved these changes
Mar 4, 2019
|
Thanks @kurkle for this prompt fix |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6104
Pen showing 6104 fixed
No regression in timing
Its fixed by making sure we are advancing whether the start time was reset or not.