Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't trigger the zoom on legends area #772

Merged
merged 3 commits into from
Nov 16, 2024
+7 −1
Merged

Don't trigger the zoom on legends area #772

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9b5165
Don't trigger the zoom on legends area
ikkala Jul 14, 2023
e1cd506
Make cleaner, suggested by @kurkle
ikkala Nov 15, 2024
26d3176
fix: lint
kurkle Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/handlers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {directionEnabled, debounce, keyNotPressed, getModifierKey, keyPressed} from './utils';
import {zoom, zoomRect} from './core';
import {callback as call, getRelativePosition} from 'chart.js/helpers';
import {callback as call, getRelativePosition, _isPointInArea} from 'chart.js/helpers';
import {getState} from './state';

function removeHandler(chart, type) {
Expand Down Expand Up @@ -58,6 +58,12 @@ function zoomStart(chart, event, zoomOptions) {
}

export function mouseDown(chart, event) {
const rect = event.target.getBoundingClientRect();
const offsetX = event.clientX - rect.left;
const offsetY = event.clientY - rect.top;
if (chart.legend && _isPointInArea({x: offsetX, y: offsetY}, chart.legend)) {
return;
}
ikkala marked this conversation as resolved.
Show resolved Hide resolved
const state = getState(chart);
const {pan: panOptions, zoom: zoomOptions = {}} = state.options;
if (
Expand Down