From 86cec22be424708b50a1eb38e236b85f4276af78 Mon Sep 17 00:00:00 2001 From: cw-sakamoto Date: Fri, 24 Nov 2023 15:30:57 +0900 Subject: [PATCH] fix createIngress conditions --- cmd/ingress/ingressCheck.go | 2 +- util/k8s/resources.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/ingress/ingressCheck.go b/cmd/ingress/ingressCheck.go index 4253900..52aa06e 100644 --- a/cmd/ingress/ingressCheck.go +++ b/cmd/ingress/ingressCheck.go @@ -134,7 +134,7 @@ func (i *Ingress) createResources() error { i.Chatwork.AddMessage(fmt.Sprintf("Error Create Service: %s", err)) return err } - if err := k.CreateIngress(i.createIngressObject(), i.NoDnsCheck); err != nil { + if err := k.CreateIngress(i.createIngressObject()); err != nil { i.Chatwork.AddMessage(fmt.Sprintf("Error Create Ingress: %s", err)) return err } diff --git a/util/k8s/resources.go b/util/k8s/resources.go index ebd7fab..0ecd687 100644 --- a/util/k8s/resources.go +++ b/util/k8s/resources.go @@ -151,7 +151,7 @@ func (k *K8s) DeleteService(serviceName string) error { return nil } -func (k *K8s) CreateIngress(ingress *networkingv1.Ingress, NoAddressCheck bool) error { +func (k *K8s) CreateIngress(ingress *networkingv1.Ingress) error { ingressClient := k.clientset.NetworkingV1().Ingresses(k.namespace) k.logger().Infof("Creating ingress: %s", ingress.Name) @@ -168,7 +168,7 @@ func (k *K8s) CreateIngress(ingress *networkingv1.Ingress, NoAddressCheck bool) return err } - if !NoAddressCheck { + if *ingress.Spec.IngressClassName == "alb" { err = wait.PollUntilContextTimeout(context.Background(), 5*time.Second, 5*time.Minute, false, func(ctx context.Context) (bool, error) { ingress, err := ingressClient.Get(ctx, ingress.Name, metav1.GetOptions{}) if err != nil {