Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get rid of the connectionToken parameter #26

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Feb 1, 2022

Che is securing the route so we don't need connectionToken parameter
It's now possible to turn off this feature in VS Code

it might fix eclipse-che/che#21099 as the gateway can know check if the server is returning 200 and it's no longer returns 403 error

Che is securing the route so we don't need connectionToken parameter
It's now possible to turn off this feature in VS Code
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-26-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-26-dev-amd64

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-26-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-26-dev-amd64

@benoitf
Copy link
Contributor Author

benoitf commented Feb 1, 2022

so while it's getting rid of the connectionToken I still have bad gateway issue

@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-26-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-26-dev-amd64

1 similar comment
@github-actions
Copy link

github-actions bot commented Feb 1, 2022

Pull Request images published ✨
image: quay.io/che-incubator-pull-requests/che-code:pr-26-amd64
Dev image: quay.io/che-incubator-pull-requests/che-code-dev:pr-26-dev-amd64

@benoitf benoitf merged commit 2fd7474 into che-incubator:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

che-code - Open IDE redirects too fast: Bad Gateway
2 participants