Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide devworkspace support, upgraded Quarkus version to 2.7.1.Final #82

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

dkwon17
Copy link
Contributor

@dkwon17 dkwon17 commented Feb 22, 2022

Related issue: eclipse-che/che#20090

This PR provides devworkspaces support by:

  • removing che.machine.token and che.api.internal config
  • reading devworkspace info via kubernetes client (fabric8)
  • retrieving username via /config/user/profile/name file

TODO: need to fix integration and native mode tests

@dkwon17 dkwon17 force-pushed the devworkspace-support branch from d75830a to 7573dea Compare February 22, 2022 14:56
@ibuziuk ibuziuk self-requested a review February 22, 2022 16:55
Copy link
Collaborator

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dkwon17 could you please take a look why CI is failing?

@dkwon17
Copy link
Contributor Author

dkwon17 commented Feb 22, 2022

@ibuziuk It is a problem with how the openapi schema is generated, I will work on a fix

@dkwon17 dkwon17 force-pushed the devworkspace-support branch 4 times, most recently from 8d874d1 to a704680 Compare February 23, 2022 21:08
Copy link
Collaborator

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job 👍

Signed-off-by: David Kwon <dakwon@redhat.com>
@dkwon17
Copy link
Contributor Author

dkwon17 commented Feb 25, 2022

Thank you @ibuziuk, I have made some changes to the native integration tests and updated the readme. This PR can be merged IMO.

@ibuziuk ibuziuk merged commit f43249c into che-incubator:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants