Only start che on minishift and minikube if userland-proxy is disabled #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iea000a65c26cca00972deea498d6131eb3c5709b Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Change-Id: I1fc854c946104586891f2c2d92fcb97229953b69 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
l0rd
reviewed
Mar 28, 2019
| @@ -100,6 +100,7 @@ | |||
| "scripts": { | |||
| "postpack": "rm -f oclif.manifest.json", | |||
| "posttest": "tslint -p test -t stylish", | |||
| "tslint-fix": "tslint --fix -p test -t stylish", | |||
There was a problem hiding this comment.
It's to auto-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure userland-proxy has been defined on minikube or minishift before deploying che.
Change-Id: Iea000a65c26cca00972deea498d6131eb3c5709b
Signed-off-by: Florent Benoit fbenoit@redhat.com