Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use maven instead of 'java -jar' to run sample #5

Merged
merged 1 commit into from
Aug 4, 2022
Merged

chore: use maven instead of 'java -jar' to run sample #5

merged 1 commit into from
Aug 4, 2022

Conversation

vitaliy-guliy
Copy link
Contributor

@vitaliy-guliy vitaliy-guliy commented Aug 3, 2022

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

For both commands to run sample, it's better to use mvn spring-boot:run instead of java -jar

Solves eclipse-che/che#20791

To test use
https://che-dogfooding.apps.che-dev.x6e0.p1.openshiftapps.com/dashboard/#/https://github.com/vitaliy-guliy/java-guestbook/tree/devfilev2

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com.com>
@benoitf
Copy link

benoitf commented Aug 3, 2022

FYI it seems your Signature has an extra .com

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com.com

Copy link
Contributor

@svor svor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@vitaliy-guliy vitaliy-guliy merged commit bf1ad67 into che-samples:devfilev2 Aug 4, 2022
@vitaliy-guliy vitaliy-guliy deleted the devfilev2 branch August 4, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants