Skip to content

Conversation

@talktovikas
Copy link
Member

@talktovikas talktovikas commented Dec 11, 2024

Description

https://progresssoftware.atlassian.net/browse/CHEF-12507
[Please describe what this change achieves]

Issues Resolved

[List any existing issues this PR resolves, or any Discourse or
StackOverflow discussions that are relevant]

Check List

lbakerchef and others added 30 commits November 25, 2024 20:50
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
It's old and unmaintained, and now it won't compile without warnings.
the last commit was 6-10 years ago.

Most of the tools within it now have more updated equivalents
elsewhere.

Choices:

1) just remove it
2) fork it, fix compile errors, maintain it
3) remove it, then when and where needed, use updated equivalents.

For now, going with #1.

Signed-off-by: Lincoln Baker <lbaker@chef.io>
Fix undefined type error and syntax error.

Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: Lincoln Baker <lbaker@chef.io>
… update.

term_to_binary changed.  This option is now needed in order to maintain
current behavior and avoid failures.

Signed-off-by: Lincoln Baker <lbaker@chef.io>
It's probably not good to have some calls using this option and other
calls not using it.

Signed-off-by: Lincoln Baker <lbaker@chef.io>
  2) /_stats API endpoint returns prometheus output ?format=text
     Failure/Error: expect(names.uniq).to match_array(PROMETHEUS_RESPONSE_TYPE_MAP.keys)

       expected collection contained:  ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"]
       actual collection contained:    ["chef_index_batch_completed_latency_ms_bucket", "chef_index_batch_completed_latency_ms_count", "chef... "pg_stat_tidx_blks_read", "pg_stat_toast_blks_hit", "pg_stat_toast_blks_read", "pg_stat_tup_fetch"]
       the missing elements were:      ["erlang_mnesia_committed_transactions", "erlang_mnesia_failed_transactions", "erlang_mnesia_held_loc...d_transactions", "erlang_mnesia_transaction_coordinators", "erlang_mnesia_transaction_participants"]
     # ./spec/api/stats_spec.rb:218:in `block (2 levels) in <top (required)>'

Signed-off-by: Lincoln Baker <lbaker@chef.io>
Erlang changed this from a default option to an option which now has to
be specified, causing failures in SSL when using a self-signed cert.

1) Server-side reindexing reindexing OPC it should behave like Reindexing works for all object types
   Failure/Error: identifiers.should_not include(name)
     expected ["pedant_node_test"] not to include "pedant_node_test"
   Shared Example Group: "Reindexing" called from ./spec/api/reindex_spec.rb:20
   # ./lib/pedant/rspec/search_util.rb:932:in `block in do_search'
   # ./lib/pedant/rspec/search_util.rb:769:in `with_search_polling'
   # ./lib/pedant/rspec/search_util.rb:919:in `do_search'
   # ./lib/pedant/rspec/search_util.rb:888:in `should_not_find'
   # ./lib/pedant/rspec/search_util.rb:950:in `block (2 levels) in <module:RSpec>'

Signed-off-by: Lincoln Baker <lbaker@chef.io>
Signed-off-by: RoyShravani <shravani.roy@progress.com>

testing with LTS-2024

Signed-off-by: RoyShravani <shravani.roy@progress.com>

adding studio secrets

adding studio secretes

Signed-off-by: RoyShravani <shravani.roy@progress.com>
Signed-off-by: jan shahid shaik <jashaik@progress.com>
@talktovikas talktovikas requested review from a team as code owners December 11, 2024 13:56
@netlify
Copy link

netlify bot commented Dec 11, 2024

👷 Deploy Preview for chef-server processing.

Name Link
🔨 Latest commit fdd336f
🔍 Latest deploy log https://app.netlify.com/sites/chef-server/deploys/675fce3c21ab9c0008d0d851

Signed-off-by: talktovikas <vikas.yadav@progress.com>
Signed-off-by: talktovikas <vikas.yadav@progress.com>
@sonarqubecloud
Copy link

@talktovikas talktovikas changed the base branch from main to CHEF-11677/CHEF-12498/lbaker December 16, 2024 07:57
@talktovikas talktovikas changed the base branch from CHEF-11677/CHEF-12498/lbaker to CHEF-11677/CHEF-12498/lbaker.1208-experimental-fixes December 16, 2024 07:57
@talktovikas talktovikas changed the base branch from CHEF-11677/CHEF-12498/lbaker.1208-experimental-fixes to CHEF-11677/CHEF-12498/lbaker December 16, 2024 07:57
@talktovikas talktovikas changed the title WIP | Building ruby against LTS channel for erchef. Building ruby against LTS channel for erchef. Dec 18, 2024
@jashaik jashaik changed the title Building ruby against LTS channel for erchef. [DO NOT MERGE] Building ruby against LTS channel for erchef. Dec 24, 2024
@lbakerchef lbakerchef force-pushed the CHEF-11677/CHEF-12498/lbaker branch from 923f57d to c86a7cc Compare June 11, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants