-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[CHEF-16732] Pipelines to build the client with habitat and deploy to chef/chef-hab docker repo #14707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHEF-16732] Pipelines to build the client with habitat and deploy to chef/chef-hab docker repo #14707
Conversation
|
Looking through this, I think most of this is valid, but we will need to also update the community and internal developers how this affects things like kitchen, and or habitat. Things to consider updating: Line 7 in 545f089
Line 9 in 545f089
Do we also want to produce a windows docker image based on the same work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
taking sometime to verify all this and looking through configurations on expeditor.
why are we switching docker hub org to chef-hab? Customers know that chef-ciient 19 is hab built package and having it in the same docker hub org chef/chef should be fine then. Just like any update they know major versions have changes in them like in this case 19 will be hab built version in the container. |
@Stromweld Pushing the hab images in the same repo as chef/chef will break the test-kitchen drivers. They currently set the path based on the repo that the image is being pulled from. |
a1063b1
to
a0d3878
Compare
Sean mentioned this is still WIP. |
@ashiqueps do we still need this? Can I close this? |
@johnmccrae yes this is needed. @ashiqueps can you pls rebase.? |
a0d3878
to
506da97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm , thanks for handling this.
3dfb4af
to
48f11ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the arm64 disabling on the main page, when it should be restored, and the changes to path that has been made.
@ashiqueps Arm support will be have to added once habitat has support for arm released. Can you pls add that in description for the PR. Arm release for hab should be planned in coming months. |
2769145
to
ed76326
Compare
@rahulgoel1, @tpowell-progress Updated the PR description and the code comments. Please review. |
…y to chef/chef-hab docker repo Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
…y to chef/chef-hab docker repo Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
Signed-off-by: Ashique Saidalavi <Ashique.saidalavi@progress.com>
ed76326
to
bc85759
Compare
|
Description
With Chef Infra Client 19, the omnibus builds are disabled and available through Habitat only. As a result, the pipelines that created the chef/chef docker image were commented out.
In this PR, I've updated the Dockerfile to build the chef-infra-client using the habitat and updated the pipelines to build it and deploy it to a different repo called chef/chef-hab.
The difference between the old chef/chef and chef/chef-hab is that chef/chef contains the omnibus version of the chef-infra-client 18 and the earlier versions where as the chef/chef-hab will contain the habitat version of chef-infra-client and newer versions.
Note:
Currently, the docker images are built for the amd64 arch only. The pipelines for arm64 have been commented out and will be added back once we have support for arm64 in chef habitat.
Related Issue
Types of changes
Checklist:
Gemfile.lock
has changed, I have used--conservative
to do it and included the full output in the Description above.