Drop FFI pin, plus a bunch of assorted other bits #14911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires the fix in Tested this with: and it builds. |
|
Looks like there's a lot more sticking us to 1.15
|
|
rest-client isn't pinned, that inherited the pin from us... so just chef-powershell. |
|
OK chef/chef-powershell-shim#288 is for chef-powershell. There's no direct dep, but it's pulled in from somewhere. |
jaymzh
force-pushed
the
ffi-ver
branch
2 times, most recently
from
0e1a97c to
40439eb
Compare
jaymzh
force-pushed
the
ffi-ver
branch
9 times, most recently
from
5e9e1f0 to
243dc8c
Compare
|
@tpowell-progress - as discussed in Slack, this needs a release of HOWEVER - any idea why |
jaymzh
force-pushed
the
ffi-ver
branch
10 times, most recently
from
edaaa49 to
0a41cc1
Compare
jaymzh
force-pushed
the
ffi-ver
branch
11 times, most recently
from
4fc3dff to
b602254
Compare
|
On both macOS 13 and 15, for some reason I'm unable to get |
|
Looks like the process is trying to update preferences in I wonder why this test attempts to modify this system preference instead of creating a test app. |
|
I applied this diff: diff --git a/spec/functional/resource/macos_userdefaults_spec.rb b/spec/functional/resource/macos_userdefaults_spec.rb
index 2d3f538cf2..5063f64db8 100644
--- a/spec/functional/resource/macos_userdefaults_spec.rb
+++ b/spec/functional/resource/macos_userdefaults_spec.rb
@@ -58,7 +58,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
context "can process expected data" do
it "set array values" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestArrayValues"
resource.value [ "/Library/Managed Installs/fake.log", "/Library/Managed Installs/also_fake.log"]
resource.run_action(:write)
@@ -66,7 +66,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
end
it "set dictionary value" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestDictionaryValues"
resource.value "User": "/Library/Managed Installs/way_fake.log"
resource.run_action(:write)
@@ -74,7 +74,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
end
it "set array of dictionaries" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestArrayWithDictionary"
resource.value [ { "User": "/Library/Managed Installs/way_fake.log" } ]
resource.run_action(:write)
@@ -82,7 +82,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
end
it "set boolean for preference value" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestBooleanValue"
resource.value true
resource.run_action(:write)
@@ -106,7 +106,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
end
it "we can delete a preference with full path" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestKey"
expect { resource.run_action(:delete) }. to_not raise_error
end
@@ -119,7 +119,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
context "resource can process FFI::Pointer type" do
it "for host property" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestDictionaryValues"
resource.value "User": "/Library/Managed Installs/way_fake.log"
resource.host :current
@@ -128,7 +128,7 @@ describe Chef::Resource::MacosUserDefaults, :macos_only do
end
it "for user property" do
- resource.domain "/Library/Preferences/ManagedInstalls"
+ resource.domain "#{ENV['HOME']}/Library/Preferences/com.chef.macos.test.preferences"
resource.key "TestDictionaryValues"
resource.value "User": "/Library/Managed Installs/way_fake.log"
resource.user :currentThis worked fine with macOS 13 and 15 with ffi v1.17.1, both precompiled and compiled versions. |
|
#14937 seems to work locally and in CI. |
* Add msys2 build-dep to windows hab so we can build libffi which is required in ffi 1.17.x * Add some post-bundle-install hacks for appbunder for ffi 1.17.x * Sort words in cspell config after adding 'autoreconf' See ffi/ffi#1139 (comment) for details ``` $ bundle update ffi ohai mixlib-log --conservative Fetching https://github.com/stanhu/mixlib-log.git Fetching https://github.com/jaymzh/ohai.git Fetching gem metadata from https://rubygems.org/....... Resolving dependencies... Resolving dependencies... Using mixlib-log 3.2.2 (was 3.0.9) from https://github.com/stanhu/mixlib-log.git (at sh-relax-ffi@6aff216) Using ohai 19.0.9 (was 19.0.5) from https://github.com/jaymzh/ohai.git (at ffi-ver@1c34928) Bundler attempted to update ffi but its version stayed the same Bundle updated! ``` Signed-off-by: Phil Dibowitz <phil@ipom.com>
|
|
The seg fault in macOS 13 came up again: https://github.com/chef/chef/actions/runs/14474375159/job/40596279236 I wonder why I can't reproduce that. |
|
The mac fixes from your PR, but not the segfault. |
|
Heh. Jinx. Yeah, it's pretty bizarre. I wonder if there's something specific to GH's runners. There's no Mac tests on BK, so no good way to compare. |
|
Oh, right, #14937 only updates the Chef tests. The actual Kitchen tests still use the There's a possibility that there is a memory access bug here with either I have to wonder if the Kitchen tests used a temporary file as #14937 does whether we'd see the seg fault. macOS 13 reaches EOL in November 2025 in any case, so I wonder if it's easier at this point to drop support for that. |
|
We can't drop support for an OS nearly a full year before it's EOL date... |
|
I wonder if we need to build the |
|
Ok, I was able to reproduce this issue on macOS 13 if I follow the Kitchen steps: brew install coreutils
sudo su
curl https://omnitruck.chef.io/install.sh | bash -s -- -P chef -c current
export PATH="/opt/chef/bin:/opt/chef/embedded/bin:$PATH"
<clone this branch>
cd chef
bundle install
gem install ohai
/opt/chef/embedded/bin/ruby /opt/chef/embedded/bin/rake install:local
gem uninstall ffi --platform x86-darwinThen I ran require 'chef'
events = Chef::EventDispatch::Dispatcher.new
node = Chef::Node.new
run_context = Chef::RunContext.new(node, {}, events)
r = Chef::Resource::MacosUserDefaults.new("Value with space", run_context).tap do |r|
r.value = [ "/Library/Managed Installs/fake.log", "/Library/Managed Installs/also_fake.log", "hello"]
r.key = "test-test"
end
r.run_action(:write)
r.get_preference(r)On macOS 13, the seg fault doesn't happen if I use the precompiled gem install ffi --platform ruby -- --disable-system-libffi --enable-libffi-allocI wonder if we can avoid the |
|
Calling @tpowell-progress on updating libffi in the omnibus build for macos. |
|
Strangely I can't reproduce the macOS 13 failure this morning on a new VM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is required in ffi 1.17.x
See ffi/ffi#1139 (comment)
for details
Signed-off-by: Phil Dibowitz phil@ipom.com