Fix commented out cops due to renames #981
Conversation
sean-simmons-progress
added
the
Triage: Needs Information
|
Quick $0.02 for Progress reviewers - a potential sticking point is specifically the cookstyle.yml changes, which as Tim pointed out will fire on downstream CI changes. Some discussion @tpowell-progress and I had (and discussed in the CAC around the time of moving Chefstyle into Cookstyle) was 'streams' (#967) to avoid that issue, but I haven't had time to get that sorted out yet. I'm personally fine with more lints enabled, but I'm not a typical customer, either ;-) |
Renames per rubocop/rubocop#7468 Signed-off-by: Tim Smith <tsmith84@gmail.com>
See rubocop/rubocop#7813 Signed-off-by: Tim Smith <tsmith84@gmail.com>
These were renamed in rubocop/rubocop#7460 Signed-off-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
Renamed in https://github.com/rubocop/rubocop/blob/e12b51389500da8e744730f8fa022d739ba0b573/relnotes/v0.89.0.md?plain=1#L50C120-L50C155 Signed-off-by: Tim Smith <tsmith84@gmail.com>
Renamed in rubocop/rubocop#4864 Signed-off-by: Tim Smith <tsmith84@gmail.com>
Renamed in rubocop/rubocop#3226 Signed-off-by: Tim Smith <tsmith84@gmail.com>
These were renamed in rubocop/rubocop#6983 Signed-off-by: Tim Smith <tsmith84@gmail.com>
Renamed in rubocop/rubocop#3797 Signed-off-by: Tim Smith <tsmith84@gmail.com>
This one was partially updated at some point, but is not right: See https://github.com/rubocop/rubocop/blob/e12b51389500da8e744730f8fa022d739ba0b573/config/obsoletion.yml#L45 Signed-off-by: Tim Smith <tsmith84@gmail.com>
Signed-off-by: Tim Smith <tsmith84@gmail.com>
tas50
force-pushed
the
tas50/fix_renames
branch
from
1501126 to
147102a
Compare
|
Checking in here 3 months later. Any chance Progress is ready to merge this now? |
Signed-off-by: Tim Smith <tsmith84@gmail.com>
tas50
force-pushed
the
tas50/fix_renames
branch
from
c81ee9e to
c2bbb73
Compare
|
|
Hey @tas50 - we'd like do a first-pass with these rules on at least the top-few chef repos (chef/chef, chef/ohai mixlib/*) so that contributors don't run into errors unrelated to their change. Would you be willing to do that, and then we can merge? If you don't have the cycles, @dafyddcrosby (community member) is willing to do it, but may not have time until May. |
Description
Fix the cops broken during one of my upgrades a long time ago. This is probably going to result in CI failures elsewhere as these cops have been disabled for a while. Test Kitchen triggered on one of the alignment cops.
Related Issue
Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.