Upgrade RuboCop to 1.75.2 + enable new cops

[tas50]

This picks up from #981 so that needs to get merged first

• Upgrade to RuboCop 1.75.2
• Bump the Ruby requirement to Ruby 3.0 by default for chefstyle and Ruby 2.6 by default for cookstyle (still allows upgrades from older client releases)
• Fix deprecation warnings from some cops that inherited from Cop instead of Base
• Correct style issues within cookstyle itself
• Enable new cops available between 1.25 -> 1.75 which made sense
• Update monkeypatch code to work with modern RuboCop
• Remove rubocop-performance as a development dep
• Modernize the autocorrection method used in Chef/Style/AttributeKeys

[johnmccrae]

Tim, I approved the other PR but I have some questions inline about this one - some of the cops appear to be duplicates of each other - the block starting around line 720 appears to be duplicated in a block at ~line 3531 or so? There's a couple of small typos that need clarifying too.

[sean-sype-simmons]

Related to: #984

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jaymzh]

This looks good to me, pending #981 stuff.

[ahasunos]

While using the tas50:tas50/bump_version branch of @tas50 to run chefstyle, I encountered a LoadError for rubocop-performance.

bundle exec cookstyle --chefstyle 

bundler: failed to load command: cookstyle (/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/bin/cookstyle)
/.rbenv/versions/3.4.1/lib/ruby/gems/3.4.0/gems/rubocop-1.71.2/lib/rubocop/feature_loader.rb:46:in 'RuboCop::FeatureLoader#load': cannot load such file -- rubocop-performance (LoadError)

I was able to get it working temporarily by adding rubocop-performance to the Gemfile.

Does this gem need to be added as part of this project?

[tas50]

@ahasunos rubocop-performance is already in one of the groups. Did you make sure to bundle install it first?

[ahasunos]

@tas50 - Oh, I see that rubocop-performance is already included in the Gemfile under the rubocop_gems group:

group :rubocop_gems do
  gem 'rubocop-performance'
end

However, since I'm using Cookstyle in my project by referencing it like this in my Gemfile:

gem "cookstyle", git: "https://github.com/tas50/cookstyle/", branch: "tas50/bump_version"

I believe this setup would install only the gems listed in the gemspec, not the ones from the Gemfile. Is that correct? 🤔

If that's the case, would it make sense to move rubocop-performance to the gemspec instead, or is it intentionally kept in the Gemfile? Just wanted to check and make sure.

[tas50]

@ahasunos I removed rubocop-performance entirely so give things a try now

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jaymzh]

3.0?

[tas50]

Cookstyle previously defaulted to 2.5, which helped with really old Infra Client upgrades. You want to upgrade your cookbooks before doing the client release. By targeting an old version of Ruby by default you can resolve deprecations in your cookbooks without any modern Ruby-isms sneaking it. If you want to target the latest Infra Client release then you can bump up the target infra client and ruby versions in a .rubocop.yml file.

I did bump Chefstyle to 3.0 though since that's really just for internal use and 2.x support in Chef projects is all gone now.

[jaymzh]

wait, why is it 2.6 here and 3.0 above?

[tas50]

Cookstyle vs. Chefstyle

[johnmccrae]

Isn't that just the ruby version whose "cops" are applied to your code? You're apply Ruby 2.6 syntax-checking and linting. I would expect Ruby 3.0 as well

[tas50]

Some cops will try to modernize your code with new methods that don't exist in old Ruby releases. If we set that to the latest and greatest Ruby releases you couldn't modernize the Chef side without introducing Ruby that old clients couldn't use. Folks can always crank that up as necessary. Ruby 2.6 is Infra Client 15.

[damacus]

Thanks for getting this merged 👍🏼

any chance we can get a release on RubyGems.org please?