-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SASS support to project #880
Add SASS support to project #880
Conversation
I love how this PR adds support for sass out of the box. But I dont want to make knowing sass a barrier to using the boilerplate. How about we keep keep the Also thanks for this PR! 😄 |
Ok so i revert to original |
Yea. also I would recommend commenting why the sass webpack configs are there. Someone may think they are unnecessary in the future and try to remove them. Comment something like 'these are hear for out of the box support for sass' |
…t entries in webpack config files
Also I forgot to ask. Does this work with live reloading? What's the performance like? |
Ok, I reverted all css files to state from master branch and short feature description in README.md. |
Does this work with hot reloading? |
Yes it is, reloads view almost instantly so I think it performs well. |
Great! Also is it possible to add the webpack configs to the webpack base config? What was the reason for adding to both dev and prod configs? Edit: Never mind. The config makes sense now! Merging 🎉 |
No description provided.