Enhance views to [sometimes] support dynamic indexing and implement FlatIO #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented by including any corresponding Aggregates from the DataView.mapping in the AggregateViewBinding.childMap (which is now of type Map[Data, Data]). This enables dynamically indexing Vecs that are themselves elements of larger Aggregates in views when the corresponding element of the view is a Vec of the same type. It also increases the number of cases where a single Target can represent part of a view.
|
Looks good as far as API is concerned. Can't comment on the implementation |
azidar
approved these changes
Apr 11, 2022
mergify bot
added a commit
that referenced
this pull request
Apr 12, 2022
…latIO (backport #2476) (#2479) * Capture 1:1 mappings of Aggregates inside of views This is implemented by including any corresponding Aggregates from the DataView.mapping in the AggregateViewBinding.childMap (which is now of type Map[Data, Data]). This enables dynamically indexing Vecs that are themselves elements of larger Aggregates in views when the corresponding element of the view is a Vec of the same type. It also increases the number of cases where a single Target can represent part of a view. (cherry picked from commit 1f6b1ca) * Add FlatIO API for creating ports from Bundles without a prefix (cherry picked from commit 772a3a1) * [docs] Add FlatIO to the general cookbook (cherry picked from commit b415964) Co-authored-by: Jack Koenig <koenig@sifive.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @davidbiancolin for the implementation idea
@oharboe I promised you this a while ago, here it finally is!
The best way to understand this PR is to look at the tests (including the
DataViewTargetSpecwhich is a subtle change but an enhancement). Basically, I changed the AggregateViewBinding to include mappings between Aggregates when there is a 1-1 correspondence. This enables dynamically indexing Vecs that are themselves elements of larger Aggregates in views when the corresponding element of the view is a Vec of the same type. It also increases the number of cases where a single Target can represent part of a view.It also enabled implementing
FlatIO(which really needed dynamic indexing to work), so I went ahead and did that too!Contributor Checklist
docs/src?Type of Improvement
API Impact
This enables dynamic indexing of more views. It also adds
chisel3.experimental.FlatIOfor creating ports without a prefix.Backend Code Generation Impact
No impact
Desired Merge Strategy
Release Notes
Enable dynamic indexing for more views. Add
chisel3.experimental.FlatIOfor creating ports from Bundles without a prefix for the name of theval.Reviewer Checklist (only modified by reviewer)
3.4.x, [small] API extension:3.5.x, API modification or big change:3.6.0)?Please Merge?