Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tilelink: More verbose require statements #2313

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Tilelink: More verbose require statements #2313

merged 1 commit into from
Feb 28, 2020

Conversation

hcook
Copy link
Member

@hcook hcook commented Feb 28, 2020

Getting a requirement failure during diplomacy execution with no further explanation is frustrating for users.

@hcook
tilelink: add more verbose requirements to edges
efb8bcd 
in particular, handle the common failure scenario where an L1 DCache is added to a design with no cacheable memory region.
@hcook hcook requested a review from terpstra February 28, 2020 18:36
mwachs5
mwachs5 approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@hcook hcook requested a review from jackkoenig February 28, 2020 19:32
@hcook hcook merged commit 1cc7887 into master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwachs5 mwachs5 mwachs5 approved these changes

@jackkoenig jackkoenig jackkoenig approved these changes

@terpstra terpstra Awaiting requested review from terpstra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hcook @jackkoenig @mwachs5