Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONTRIBUTING.md with instructions to bump submodules #2342

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

jackkoenig
Copy link
Contributor

Mainly to mention that chisel3 and firrtl should only be bumped to
stable branches

Related issue: NA

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

Add CONTRIBUTING.md with instructions to bump submodules

Mainly to mention that chisel3 and firrtl should only be bumped to
stable branches
Co-Authored-By: Megan Wachs <megan@sifive.com>
Copy link
Contributor

@mwachs5 mwachs5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, obviously this is not a complete "contribution guidelines" but it's good to have the Chisel/FIRRTL bumping instructions written down clearly

@jackkoenig
Copy link
Contributor Author

Yeah I didn't feel super inclined to try to write a full guide but at least it's a start!

@jackkoenig jackkoenig merged commit 0086e6c into master Mar 18, 2020
@jackkoenig jackkoenig deleted the chisel-firrtl-bump-docs branch March 18, 2020 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants