AsyncResetReg: use chisel3 resets #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
While chisel3 now provides native AsyncReset support, some code bases may still be making use of the
AsyncResetRegmodules and helpers which wrap it. Although those helpers cast the resets internally as needed to generateAsyncReset, they are intolerant of themselves being driven byAsyncResetbecause they are currentlyChisel._modules and expect onlyBoolresets.Use the compatibility options that allow these to accept resets of any type.
It's probably worth deprecating some of these interfaces, but i have not done that in this PR.
Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes
Enable
AsyncResetReg,AsyncResetRegVecmodules and helpers to be used within modules withchisel3AsyncReset