GitHub Actions: Install the same packages in all jobs. #2536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub seems to have a very high failure rate when restoring artifacts from the cache. When this happens, the build will attempt to compile some of the cached artifacts, such as riscv-tools, from scratch. Because we were not installing all of the packages required for building the artifacts in the later jobs, if the cache restoration step fails, then the build will fail. Installing the same packages across all jobs will ensure that even if the cache fails to restore, then our jobs will still succeed, albeit more slowly.
richardxia
requested review from
hcook,
aswaterman,
terpstra,
jackkoenig and
mwachs5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
GitHub seems to have a very high failure rate when restoring artifacts from the cache. When this happens, the build will attempt to compile some of the cached artifacts, such as riscv-tools, from scratch. Because we were not installing all of the packages required for building the artifacts in the later jobs, if the cache restoration step fails, then the build will fail.
Installing the same packages across all jobs will ensure that even if the cache fails to restore, then our jobs will still succeed, albeit more slowly.