CI: compile using wake 0.18.1 #2584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one turned out to be very easy. |
richardxia
approved these changes
Aug 4, 2020
| @@ -34,5 +34,5 @@ echo "Compile Scala" | |||
|
|
|||
| export WAKE_PATH=$PATH | |||
| wake --init . | |||
| wake --no-tty -p1 -dv 'compileScalaModule rocketchipScalaModule | getPathResult' | |||
| wake -x 'compileScalaModule rocketchipScalaModule | getPathResult' | |||
There was a problem hiding this comment.
Is there a reason you got rid of the --no-tty? I think this affects the carriage return thing for "progress bars", and in CI, when you don't really have a real TTY, it often ends up creating a newline for each carriage return as well.
There was a problem hiding this comment.
Wake does not need to be told there is no tty. It auto-detects this.
The only reason to use --no-tty is if you actually DO have a tty, but don't want the bars.
There was a problem hiding this comment.
Ah, I see that you're right. I took a quick look at the actual CI console log from this PR and saw some progress bars, but after taking a closer look, I see that they're actually from curl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Stop regressing on wake 0.18 support; compile using 0.18.1 instead of 0.17.2.