Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestiges of Travis CI. #2647

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Remove vestiges of Travis CI. #2647

merged 1 commit into from
Mar 17, 2022

Conversation

richardxia
Copy link
Member

Related issue:

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes

Removed all mentions of Travis CI, including the .travis.yml file, since we don't have Travis CI enabled on this repo anymore.

This also updates the status badge in the README to use the GitHub Actions status badge, not the Travis CI one, which is presumably frozen in time to the last build that Travis CI ever ran, which is some time in the past.

@@ -1,4 +1,4 @@
Rocket Chip Generator :rocket: [![Build Status](https://travis-ci.org/chipsalliance/rocket-chip.svg?branch=master)](https://travis-ci.org/chipsalliance/rocket-chip)
Rocket Chip Generator :rocket: ![Build Status](https://github.com/chipsalliance/rocket-chip/workflows/Continuous%20Integration/badge.svg?branch=master)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This removes the hyperlink that wrapped the image and that pointed to the latest build page, since there does not appear to be a way to get a static URL to the "latest" run of a workflow in GitHub Actions.

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a very high level, I'm good with fully adopting GitHub actions and not straddling two CI flows (for reasons including: actions are already load bearing, Travis is not load bearing, actions is objectively better and faster than Travis, we're not running Travis, etc.). However, GitHub actions only got into public beta of GitHub Enterprise Server in 2.22 (https://github.blog/2020-09-23-github-enterprise-server-2-22/). It may be better to wait until this is at least fully supported there as there may be legacy users that are still reliant on running their own Travis CI tests from a GHE server instance.

Travis is arguably not "part of the public API", but maybe we can wait until the first GHE server release that fully supports actions.

@richardxia
Copy link
Member Author

However, GitHub actions only got into public beta of GitHub Enterprise Server in 2.22 (https://github.blog/2020-09-23-github-enterprise-server-2-22/). It may be better to wait until this is at least fully supported there as there may be legacy users that are still reliant on running their own Travis CI tests from a GHE server instance.

I didn't realize that GH Enterprise lagged so far behind cloud, since GH Actions went out of beta in the cloud just a bit under a year ago. I think I'm fine with waiting for GH Enterprise to get Actions out of beta, since according to their roadmap, the non-beta version of GH Actions is currently targeting Q4 of this year. (The ticket corresponding to the beta release was closed a couple days ago, so this other ticket refers to the non-beta release).

@richardxia
Copy link
Member Author

Just checking back on this, and it looks like GitHub slightly changed their roadmap projections for GH Actions on Enterprise to be out of Beta in Q1 2021. Will check back again in April.

@jackkoenig
Copy link
Contributor

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Mar 17, 2022

rebase

✅ Branch has been successfully rebased

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: richardxia / name: Richard Xia (f89a707)

@richardxia
Copy link
Member Author

Just checking back on this, and it looks like GitHub slightly changed their roadmap projections for GH Actions on Enterprise to be out of Beta in Q1 2021. Will check back again in April.

I never said anything about which year's April I'd check back in on. (Thanks, @jackkoenig for rebasing this.)

@richardxia richardxia merged commit 649ac93 into master Mar 17, 2022
@richardxia richardxia deleted the remove-travis-ci branch March 17, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants