Enable ProcedureSyntax lint rule #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardxia
requested review from
terpstra,
albertchen-sifive,
aswaterman,
hcook,
jackkoenig,
mmjconolly,
seldridge and
azidar
|
Why do we want to do this? The procedure-style syntax is unambiguous. |
It will no longer supported in Scala 3: https://dotty.epfl.ch/docs/reference/dropped-features/procedure-syntax.html |
aswaterman
approved these changes
Oct 2, 2020
seldridge
approved these changes
Oct 2, 2020
hcook
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Followup to #2648. Compared to #2650, this lint rule requires modifying a much larger number of lines of code in rocket-chip.
This PR enables the
ProcedureSyntaxlint rule in Scalafix. A deprecated syntax of Scala was to allow for a Java/C-style method declaration that did not require an explicit=separating the method name and type signature from the body of the method. This lint rule detects instances of that older syntax and will change them to 1) have the explicit return type ofUnitand 2) to place an=between the return type and the opening curly brace of the method body.