Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FESVR: Bump riscv-isa-sim to the latest to pick up DMACTIVE fix #5

Merged
merged 10 commits into from
Feb 13, 2020

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented Feb 10, 2020

See description(s) in

riscv-software-src/riscv-isa-sim#392
chipsalliance/rocket-chip#2205
riscv-collab/riscv-openocd@906635c

This PR has massively increased in scope. In order to be able to bump spike annd OpenOCD, we also need to bump riscv-tests and GDB. It turns out GDB is now better maintained on FSF not riscv-binutils-gdb, so this PR is now attempting to install the FSF version instead.

@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 10, 2020

Note this pulls in a bunch of other changes, I am not familiar if those will cause other issues.

@aswaterman
Copy link
Member

aswaterman commented Feb 10, 2020 via email

@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 11, 2020

They caused other issues :( I think we'll need to look at riscv-tests as well.

@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 13, 2020

FYI @erikdanie... working to get a set of OpenOCD/GDB/riscv-tests that passes all tests.

@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 13, 2020

@aswaterman , @jim-wilson I am not entirely sure the --disable-gdb argument is doing the right thing and the right FSF GDB is being used. I have this version of the tools installed locally... is there a way to check I am using the FSF GDB not the riscv-binutils-gdb?

@aswaterman
Copy link
Member

@mwachs5 I confirmed that it's building the right one, and that --disable-gdb worked.

@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 13, 2020

Thanks @timsifive . FSF 8.3.1 resolved the failing test. Hoping this passes all tests now.

@mwachs5
Copy link
Contributor Author

mwachs5 commented Feb 13, 2020

@aswaterman does your approval still count against this much bigger PR?

@aswaterman
Copy link
Member

Yes (thanks for checking :))

@mwachs5 mwachs5 merged commit b25b64d into master Feb 13, 2020
@erikdanie
Copy link

@mwachs5 Should I try running the fpgatests with this? If so, how do I pick it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants