-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FESVR: Bump riscv-isa-sim to the latest to pick up DMACTIVE fix #5
Conversation
Note this pulls in a bunch of other changes, I am not familiar if those will cause other issues. |
🤞
…On Mon, Feb 10, 2020 at 11:51 AM Megan Wachs ***@***.***> wrote:
Note this pulls in a bunch of other changes, I am not familiar if those
will cause other issues.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#5?email_source=notifications&email_token=AAH3XQUXQBDGFNI765NZSR3RCGH35A5CNFSM4KSSWBG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELJOX4A#issuecomment-584248304>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAH3XQS76HWAOFUSWJQYU6TRCGH35ANCNFSM4KSSWBGQ>
.
|
They caused other issues :( I think we'll need to look at riscv-tests as well. |
FYI @erikdanie... working to get a set of OpenOCD/GDB/riscv-tests that passes all tests. |
@aswaterman , @jim-wilson I am not entirely sure the |
@mwachs5 I confirmed that it's building the right one, and that --disable-gdb worked. |
Thanks @timsifive . FSF 8.3.1 resolved the failing test. Hoping this passes all tests now. |
@aswaterman does your approval still count against this much bigger PR? |
Yes (thanks for checking :)) |
@mwachs5 Should I try running the fpgatests with this? If so, how do I pick it up? |
See description(s) in
riscv-software-src/riscv-isa-sim#392
chipsalliance/rocket-chip#2205
riscv-collab/riscv-openocd@906635c
This PR has massively increased in scope. In order to be able to bump spike annd OpenOCD, we also need to bump riscv-tests and GDB. It turns out GDB is now better maintained on FSF not riscv-binutils-gdb, so this PR is now attempting to install the FSF version instead.