Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#36) Add rule for validating usage of notSilent tag #54

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

AdmiringWorm
Copy link
Member

Description Of Changes

This implements a new note rule for CPMR0067 that checks if the tag
notSilent has been used or not.

Motivation and Context

We want to cover as many rules as we can that is currently implemented in Package Validator.

Testing

  1. Create a nuspec file.
  2. Update the tags element to contain the tag notSilent
  3. Run choco pack on the created nuspec file.
  4. Verify the rule CPMR0067 is flagged.
  5. Repeat previous steps with different letter casing.

Operating Systems Testing

  • Windows 10

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v3 compatibility checked?

Related Issue

Fixes #36

@AdmiringWorm
Copy link
Member Author

AdmiringWorm commented Nov 28, 2024

Ignore the GHA build for now. Instead, check the internal build instead.

EDIT:

PR #56 should be merged before this one

This implements a new note rule for CPMR0067 that checks if the tag
`notSilent` has been used or not.
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 enabled auto-merge December 5, 2024 08:36
@gep13 gep13 merged commit 4355968 into chocolatey-community:develop Dec 5, 2024
1 check passed
@AdmiringWorm AdmiringWorm deleted the issue36 branch December 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement note rule CPMR0067 - notSilent tag is being used
2 participants