Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wixtoolset.nuspec #2565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

A9G-Data-Droid
Copy link

Remove dotnet3.5 dependency.

To address #2564

Description

The dependency was removed from wix 3.14 and yet it remains in the choco install.

Motivation and Context

I don't want to install dotnet3.5 when I choco install wix.

How Has this Been Tested?

No. After reading the test instructions I am not in a place to setup the test environment.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

Remove dotnet3.5 dependency.
@A9G-Data-Droid A9G-Data-Droid requested a review from gep13 as a code owner November 7, 2024 19:25
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

Copy link
Member

@TheCakeIsNaOH TheCakeIsNaOH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be tested in the Chocolatey Test Environment as per the PR checklist.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(wixtoolset) Version 3.14+ removed the dotnet3.5 dependency
5 participants