-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(libreoffice) Clarify package update lagging behind software release and where to raise issues / questions #1804
Conversation
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
eaf1a6e
to
8a76f16
Compare
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some formatting issues that needs to be fixed, otherwise this looks good to me.
Thanks @AdmiringWorm. I'll get that space removed (can't believe I didn't see it! 😄 ). I'll fixing up the other PR's too as they will likely have the same issue. |
@pauby I have fixed it up on the other PR's you made, I didn't notice the space until after I had merged those. |
8a76f16
to
9afd329
Compare
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
Updated this PR with those changes.
If it's not going to render properly in those other packages, do you want me to fix them? |
@AdmiringWorm Going to put this into Draft just now as I may as well add this to it while I'm here. |
Questions are still being asked via Disqus for many packages. As Disqus is generally not responded to it makes sense to clarify where questions and issues should be raised. The update of this package lags behind the software release. So we should clarify how this works.
9afd329
to
5ebeac3
Compare
@AdmiringWorm This is ready for review again. |
❌ Package verification failed, please review the Appveyor Logs and the provided Artifacts before requesting a human reviewer to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pauby your changes have been merged, thanks for your contribution 👍 |
Description
I've updated the README*.md files for libreoffice. These should flow into the 'description` in the .nupspec file.
Note that how we add this info, the message and the formatting are all up for debate. I wanted to get something up here for discussion. Once agreed, I feel we should require any updates to a package to add this to the README files (perhaps by adding it to #1754).
Closes #1803.
Motivation and Context
Questions are still being asked via Disqus for many packages. As Disqus is generally not responded to it makes sense to clarify where questions and issues should be raised. Going forward we should add this to all packages.
How Has this Been Tested?
I haven't tested this as it was an update to Markdown.
Types of changes
Checklist: