Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WinPCap) Update for AHK V2 to work #2540

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tunisiano187
Copy link
Contributor

Description

Launch install from ps1 script directly and update the AHK file
Still needs :

  • the version to be manualy updated before pack
  • to be pushed to the community repo as it's not in automatic folder

Motivation and Context

The AutoHotkey script wasn't working anymore

How Has this Been Tested?

Tested in vagrant test, directly and as the depedency of snort

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@AdmiringWorm AdmiringWorm requested review from a team and Windos and removed request for a team October 25, 2024 15:52
@Windos
Copy link
Member

Windos commented Nov 5, 2024

The changes in the PR look good, and I have tested the package in both the Chocolatey Test Environment and directly on one of my test VMs. In both environment it installed without issue.

Only one thing to note is that the uninstall is not silent. Should there be an AHK script invoked for that (I'm not actually 100% sure if there is official guidance one that)?

@AdmiringWorm - More of a process/repo question, if this is getting updated, should it be moved out of the deprecated directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants