Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freecad): update release name regex #2578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rotzbua
Copy link

@Rotzbua Rotzbua commented Nov 22, 2024

Description

Match new names with v1:

  • FreeCAD_1.0.0-conda-Windows-x86_64-installer-1.exe
  • FreeCAD_1.0.0-conda-Windows-x86_64-py311.7z

Motivation and Context

Missing update to v1.

How Has this Been Tested?

Regex tester.

Screenshot (if appropriate, usually isn't needed):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Migrated package (a package has been migrated from another repository)

Checklist:

  • My code follows the code style of this repository.
  • My change requires a change to documentation (this usually means the notes in the description of a package).
  • I have updated the documentation accordingly (this usually means the notes in the description of a package).
  • I have updated the package description and it is less than 4000 characters.
  • All files are up to date with the latest Contributing Guidelines
  • The added/modified package passed install/uninstall in the Chocolatey Test Environment(https://github.com/chocolatey-community/chocolatey-test-environment/). Note that we don't support the use of any other environment.
  • The changes only affect a single package (not including meta package).

Original Location

Release v1:
https://github.com/FreeCAD/FreeCAD/releases/tag/1.0.0

Match new names with v1:
FreeCAD_1.0.0-conda-Windows-x86_64-installer-1.exe
FreeCAD_1.0.0-conda-Windows-x86_64-py311.7z
@AppVeyorBot
Copy link

✅ Package verification completed without issues. PR is now pending human review

@Rotzbua Rotzbua mentioned this pull request Nov 28, 2024
5 tasks
@luzpaz
Copy link

luzpaz commented Dec 2, 2024

Does this need a 'Needs Review' label ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants