Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(build) Install dotnet-6.0-runtime for QA Build #1043

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Windos
Copy link
Member

@Windos Windos commented Apr 3, 2024

Description Of Changes

This PR installs the dotnet-6.0-runtime package required for the QA Build / Dependency-Check to run.

Motivation and Context

Older versions of the build agent had this baked in, but it is no longer in newer versions. Instead of re-introducing it to the build agent image, we'll install it when needed in order to run the Dependency-Check task.

Testing

To test that the build agents can install dotnet-6.0-runtime and that installing it allows the Dependency-Check task to run, the user data script was temporarily amended to add this install at that point in the build process.

This worked and the Dependency-Check task ran as expected.

Operating Systems Testing

  • Windows Server 2019

Change Types Made

Build

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@Windos Windos requested a review from gep13 April 3, 2024 22:28
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 merged commit bd224fd into chocolatey:develop Apr 4, 2024
2 checks passed
@gep13
Copy link
Member

gep13 commented Apr 4, 2024

@Windos thanks for getting this added!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants