Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Mono add support for running choco.exe not just choco #2362

Closed
TheCakeIsNaOH opened this issue Sep 17, 2021 · 0 comments · Fixed by #2365
Closed

Docker Mono add support for running choco.exe not just choco #2362

TheCakeIsNaOH opened this issue Sep 17, 2021 · 0 comments · Fixed by #2365
Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Milestone

Comments

@TheCakeIsNaOH
Copy link
Member

When running in a Linux docker container, it currently only adds choco to the path.
On windows, running either choco or choco.exe works.
Therefore, the linux docker container should add choco.exe to the path to help compatibility with preexisting commands and scripts.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (chocolatey#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (chocolatey#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning
about the directory not being found (chocolatey#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (chocolatey#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (chocolatey#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning
about the directory not being found (chocolatey#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
@gep13 gep13 added this to the vNext milestone Sep 17, 2021
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (chocolatey#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (chocolatey#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning
about the directory not being found (chocolatey#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
@gep13 gep13 added 4 - Done NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. and removed 3 - Review labels Sep 17, 2021
@gep13 gep13 closed this as completed Sep 17, 2021
gep13 pushed a commit that referenced this issue Sep 21, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (#2360). Create the "lib" directory to prevent the warning
about the directory not being found (#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants