Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux docker includes source code #2364

Closed
TheCakeIsNaOH opened this issue Sep 17, 2021 · 0 comments · Fixed by #2365
Closed

Linux docker includes source code #2364

TheCakeIsNaOH opened this issue Sep 17, 2021 · 0 comments · Fixed by #2365
Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Milestone
0.12.0

Comments

@TheCakeIsNaOH
Copy link
Member

The Linux Dockerfile currently produces an image that includes the choco source code and all build artifacts.

It would be a good idea to only include the final build artifacts the in the official image.
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 17, 2021
@TheCakeIsNaOH
(chocolatey#2364) Rework Linux Dockerfile
41181af 
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (chocolatey#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (chocolatey#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning
about the directory not being found (chocolatey#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Sep 17, 2021
Merged
TheCakeIsNaOH added a commit to TheCakeIsNaOH/choco that referenced this issue Sep 17, 2021
@TheCakeIsNaOH
(chocolatey#2364) Rework Linux Dockerfile
1833156 
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (chocolatey#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (chocolatey#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning
about the directory not being found (chocolatey#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
@gep13 gep13 added this to the vNext milestone Sep 17, 2021
gep13 pushed a commit to TheCakeIsNaOH/choco that referenced this issue Sep 17, 2021
@TheCakeIsNaOH @gep13
(chocolatey#2364) Rework Linux Dockerfile
966b11e 
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (chocolatey#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (chocolatey#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning
about the directory not being found (chocolatey#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
gep13 added a commit that referenced this issue Sep 17, 2021
@gep13
Merge pull request #2365 from TheCakeIsNaOH/dockerfile
874fb5a 
(#2364) Rework Linux Dockerfile
@gep13 gep13 added 4 - Done NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product. and removed 3 - Review labels Sep 17, 2021
@gep13 gep13 closed this as completed Sep 17, 2021
gep13 added a commit that referenced this issue Sep 19, 2021
@gep13
(#2364) Mark wrapper as executable
b58f263 
Without this done, when attempting to run choco or choco.exe within the
container fails with a permission issue.

Updating this file was done by running chmod +x on the file.
gep13 added a commit that referenced this issue Sep 19, 2021
@gep13
(#2364) Set env variable when using official build
4a413d2 
When running the official build of Chocolatey within the contianer, we
also want to switch the strong name key that is used as part of the
build.

This is done by setting the CHOCOLATEY_OFFICIAL_KEY environment variable
to the location that this file can be found.
gep13 pushed a commit that referenced this issue Sep 21, 2021
@TheCakeIsNaOH @gep13
(#2364) Rework Linux Dockerfile
af83110 
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (#2360). Create the "lib" directory to prevent the warning
about the directory not being found (#2363).

The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
gep13 added a commit that referenced this issue Sep 21, 2021
@gep13
(#2364) Mark wrapper as executable
0373e00 
Without this done, when attempting to run choco or choco.exe within the
container fails with a permission issue.

Updating this file was done by running chmod +x on the file.
gep13 added a commit that referenced this issue Sep 21, 2021
@gep13
(#2364) Set env variable when using official build
ed903fa 
When running the official build of Chocolatey within the contianer, we
also want to switch the strong name key that is used as part of the
build.

This is done by setting the CHOCOLATEY_OFFICIAL_KEY environment variable
to the location that this file can be found.
TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/choco that referenced this issue Sep 22, 2021
@gep13 @TheCakeIsNaOH
(chocolatey#2364) Mark wrapper as executable
c358874 
Without this done, when attempting to run choco or choco.exe within the
container fails with a permission issue.

Updating this file was done by running chmod +x on the file.
TheCakeIsNaOH pushed a commit to TheCakeIsNaOH/choco that referenced this issue Sep 22, 2021
@gep13 @TheCakeIsNaOH
(chocolatey#2364) Set env variable when using official build
c63c884 
When running the official build of Chocolatey within the contianer, we
also want to switch the strong name key that is used as part of the
build.

This is done by setting the CHOCOLATEY_OFFICIAL_KEY environment variable
to the location that this file can be found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released BuildAutomation NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product.
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

(#2364) Rework Linux Dockerfile TheCakeIsNaOH/choco
2 participants
@gep13 @TheCakeIsNaOH