(#2364) Rework Linux Dockerfile #2365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gep13
requested changes
Sep 17, 2021
TheCakeIsNaOH
force-pushed
the
dockerfile
branch
from
41181af
to
1833156
Compare
gep13
approved these changes
Sep 17, 2021
gep13
reviewed
Sep 17, 2021
Rework the Dockerfile for Linux. Move to a multi-stage build so the source code is not brought along into the final image (chocolatey#2364). Add build args to select the build script and mono version to use. Remove deprecated MAINTAINER instruction and add metadata with LABEL (chocolatey#2361). Add "choco.exe" to path, so both "choco" and "choco.exe" can be used, like Windows supports (chocolatey#2362). Change the install location to "/opt/chocolatey" as that is more in line with the Linux filesystem hierarchy (chocolatey#2360). Create the "lib" directory to prevent the warning about the directory not being found (chocolatey#2363). The choco_official_wrapper is used for official builds, where the "--allow-unofficial" argument is not needed.
|
@TheCakeIsNaOH I rebased this PR on the head of the stable branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the Dockerfile for Linux. Move to a multi-stage build so the
source code is not brought along into the final image (#2364). Add
build args to select the build script and mono version to use. Remove
deprecated MAINTAINER instruction and add metadata with LABEL (#2361).
Add "choco.exe" to path, so both "choco" and "choco.exe" can be used,
like Windows supports (#2362). Change the install location to
"/opt/chocolatey" as that is more in line with the Linux filesystem
hierarchy (#2360). Create the "lib" directory to prevent the warning
about the directory not being found (#2363).
The choco_official_wrapper is used for official builds, where the
"--allow-unofficial" argument is not needed.
Fixes: #2360
Fixes: #2361
Fixes: #2362
Fixes: #2363
Fixes: #2364
The debug and official build scripts are in #2359